Skip to content

Improve the iOS simulator install logic #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

Improve the iOS simulator install logic #1368

merged 1 commit into from
Jun 28, 2023

Conversation

@a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Jun 28, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Add logic to check which versions of iOS/tvOS are available, and fallback to the latest if the requested one isn't available. Also change to using xcodes to install iOS simulators, since xcode-install has been deprecated in favor of it.

This is the same change as firebase/firebase-unity-sdk#774, but for the C++ repo.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice requested a review from sunmou99 June 28, 2023 17:34
@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jun 28, 2023
@a-maurice a-maurice merged commit 71e8a1e into main Jun 28, 2023
@a-maurice a-maurice deleted the am-ios_installs branch June 28, 2023 18:41
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @a-maurice on commit 71e8a1e
Last updated: Wed Jun 28 14:24 PDT 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAppCheckTest.TestDebugProviderValidToken
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

jonsimantov
jonsimantov reviewed Jun 28, 2023
View reviewed changes
scripts/gha/test_simulator.py

# If the requested version is available, use it, otherwise default to the latest
if (device_os not in available_versions):
logging.warning("Unable to find version %s, will fall back to %s", device_os, available_versions[-1])
Copy link
Contributor

@jonsimantov jonsimantov Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If running in GitHub mode (--ci), print this out in the GitHub warning format to surface it to the overall log.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 28, 2023
@a-maurice a-maurice mentioned this pull request Jun 28, 2023
Merged
3 tasks
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

+1 more reviewer

@jonsimantov jonsimantov jonsimantov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a-maurice @jonsimantov @sunmou99